Skip to content

Corrected minor typos on Arrays page #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Corrected minor typos on Arrays page #215

wants to merge 1 commit into from

Conversation

selwynjacob90
Copy link
Contributor

1)Correct a typo in the second example under join
2)Correct the method name from pop to push under shift queue example

@selwynjacob90
Correct minor typos
cf17501 
1)Correct a typo in the second example under join
2)Correct the method name from pop to push under shift queue example
@ajpiano
Copy link
Member

ajpiano commented Jan 18, 2013

Hi @Selwyn

Thanks!

The first example is not a typo, it's demonstrating that .join with no arguments uses a default delimiter of a comma. Do you want to fix up this PR to remove that change?

@ajpiano ajpiano closed this in 963b26e Feb 12, 2013
@rmurphey rmurphey mentioned this pull request Feb 24, 2013
Closed
arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
@selwynjacob90 @ajpiano
JavaScript 101/Arrays: Correct the method name from pop to push under…
358294c 
… shift queue example. Fixes jquery#215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selwynjacob90 @ajpiano